KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18834 )
Change subject: [tool] Add output format for 'table list' CLI tool. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/18834/8/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18834/8/src/kudu/tools/kudu-tool-test.cc@3287 PS8, Line 3287: lines[2] > Please add an ASSERT on the size of the 'lines' array (to be at least of si Done http://gerrit.cloudera.org:8080/#/c/18834/8/src/kudu/tools/kudu-tool-test.cc@3287 PS8, Line 3287: string auto_table_name = lines[2].erase(0,lines[2].find_first_not_of(' ')); > nit: add a space after comma Done -- To view, visit http://gerrit.cloudera.org:8080/18834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aaec73e18872fc93646e9c0ea675b578b0702f0 Gerrit-Change-Number: 18834 Gerrit-PatchSet: 8 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 22 Aug 2022 02:03:44 +0000 Gerrit-HasComments: Yes
