Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18813 )
Change subject: [tools] Add --fault_tolerant to 'kudu table copy/scan' ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/18813/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18813/1//COMMIT_MSG@10 PS1, Line 10: are drop 'are' http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc@102 PS1, Line 102: in primary key order in primary key order for a single tablet ? http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc@103 PS1, Line 103: This also means the scanner can recover if the server it " : "is scanning fails in the middle of a scan. I guess this part should come first in the description. The fact that the per-tablet results come in primary key order is just an extra feature, right? http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc@676 PS1, Line 676: // TODO(yingchun): push down this judgement to ScanConfiguration::SetFaultTolerant I'm not sure I understand how ScanConfiguration() could have such a responsibility -- it has only the mode that it given to be set. http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc@678 PS1, Line 678: is conflict conflicts http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: PS1: If adding new flags for the kudu CLI tool, please update corresponding tests. -- To view, visit http://gerrit.cloudera.org:8080/18813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a05792db9dceb5e774ce1602158bb636bba04d0 Gerrit-Change-Number: 18813 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 29 Aug 2022 19:49:54 +0000 Gerrit-HasComments: Yes
