Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18813 )
Change subject: [tools] Add --fault_tolerant to 'kudu table copy/scan' ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/18813/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18813/4/src/kudu/tools/kudu-tool-test.cc@3696 PS4, Line 3696: cluster_->master()->bound_rpc_addr().ToString(), kTableName), Could you also add test coverage for the `kudu table copy` tool since the new flags have been added there as well? http://gerrit.cloudera.org:8080/#/c/18813/4/src/kudu/tools/kudu-tool-test.cc@3710 PS4, Line 3710: I'm not sure this exactly the test coverage assumed: as far as I can see, this patch reads and applies FLAGS_fault_tolerant for `kudu table scan` sub-command, not for `kudu perf table_scan`. With that, could you also update the `kudu perf table_scan` to report --fault_tolerant as a supported flag? And add a test for `kudu table scan` using the --fault_tolerant flag? http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/table_scanner.cc@676 PS1, Line 676: // TODO(yingchun): push down this judgement to ScanConfiguration::SetFaultTolerant > No, I think it should be validated it in ScanConfiguration internally, then OK, that sounds better to me: basically the idea is to check whether the explicit setting of the read mode for a scanner and calling SetFaultTolerant() contradict each other. http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: PS1: > In https://gerrit.cloudera.org/c/18813/4/src/kudu/tools/kudu-tool-test.cc#3 Ah, right, but that's only for the 'perf' sub-command as of now? Could you please also add coverage for the rest of sub-commands updated in this patch? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a05792db9dceb5e774ce1602158bb636bba04d0 Gerrit-Change-Number: 18813 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 31 Aug 2022 19:13:49 +0000 Gerrit-HasComments: Yes
