Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18813 )
Change subject: [tools] Add --fault_tolerant to some CLI tools ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/18813/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18813/4/src/kudu/tools/kudu-tool-test.cc@3696 PS4, Line 3696: > Could you also add test coverage for the `kudu table copy` tool since the n Done http://gerrit.cloudera.org:8080/#/c/18813/4/src/kudu/tools/kudu-tool-test.cc@3710 PS4, Line 3710: --fault_tolerant > I'm not sure this exactly the test coverage assumed: as far as I can see, t You're right, I miss it. Done http://gerrit.cloudera.org:8080/#/c/18813/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: PS1: > Ah, right, but that's only for the 'perf' sub-command as of now? Done -- To view, visit http://gerrit.cloudera.org:8080/18813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a05792db9dceb5e774ce1602158bb636bba04d0 Gerrit-Change-Number: 18813 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 02 Sep 2022 09:17:35 +0000 Gerrit-HasComments: Yes
