Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18835 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 2) ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/18835/4/src/kudu/client/table_alterer-internal.cc File src/kudu/client/table_alterer-internal.cc: http://gerrit.cloudera.org:8080/#/c/18835/4/src/kudu/client/table_alterer-internal.cc@131 PS4, Line 131: s.spec->data_->primary_k > (a) Cool, but in PS5 I still see the restriction on s.spec->data_->immutabl (a) Oh, sorry about that, I foget to remove it :( (b) I didn't add server-side check for it indeed. In fact, I followed how 'type' and 'nullable' attributes are checked, they have no checks in the server-side if I didn't miss anything. (The checks should be placed in SchemaBuilder::ApplyColumnSchemaDelta or ColumnSchema::ApplyDelta IMO) -- To view, visit http://gerrit.cloudera.org:8080/18835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id301e313eedd9cc3a494d6b4f3c14fbabe63b436 Gerrit-Change-Number: 18835 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 13:22:42 +0000 Gerrit-HasComments: Yes
