Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18835 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 2) ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/client/client-test.cc@3115 PS5, Line 3115: TEST_F(ClientTest, TestDeleteIgnore) { > nit: Missing NO_FATALS? Same elsewhere. Done http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/client/client-test.cc@8703 PS5, Line 8703: > Why this operation is not counted as a successful update? As you can see here [1], only one metric will be increment once. 1. https://github.com/apache/kudu/blob/master/src/kudu/tablet/ops/write_op.cc#L491 http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/client/client-test.cc@8785 PS5, Line 8785: s > Why this operation is not counted as a successful upsert? Same, only one metric will be increment once. http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/tablet/tablet.cc@855 PS5, Line 855: if (!upsert->has_result()) { > nit: Is it ok to call upsert->SetErrorIgnored()? Done -- To view, visit http://gerrit.cloudera.org:8080/18835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id301e313eedd9cc3a494d6b4f3c14fbabe63b436 Gerrit-Change-Number: 18835 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 13:47:06 +0000 Gerrit-HasComments: Yes
