Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18835 )
Change subject: KUDU-3353 [schema] Add an immutable attribute on column schema (part 2) ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18835/5/src/kudu/client/client-test.cc@8703 PS5, Line 8703: > As you can see here [1], only one metric will be increment once. The newly added UPSERT_IGNORE /UPDATE_IGNORE ops are not totally 'ignored' by the tablet server, some column values are updated and the immutable column values are not. This is different from the previous INSERT_IGNORE/UPDATE_IGNORE/DELETE_IGNORE ops which are completely ignored. Maybe we need new metrics for these partially ignored ops or we can count them as successful updates/upserts? -- To view, visit http://gerrit.cloudera.org:8080/18835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id301e313eedd9cc3a494d6b4f3c14fbabe63b436 Gerrit-Change-Number: 18835 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 01 Sep 2022 02:48:32 +0000 Gerrit-HasComments: Yes
