Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18813 )
Change subject: [tools] Add --fault_tolerant to some CLI tools ...................................................................... Patch Set 6: Verified+1 (1 comment) Unrelated build fluke (RELEASE): it might be something related to workspace pollution (due to the upgrade to googletest 1.12.1, propably?) http://gerrit.cloudera.org:8080/#/c/18813/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18813/6/src/kudu/tools/kudu-tool-test.cc@5055 PS6, Line 5055: TEST_F(ToolTest, TableScanFaultTolerant) { > IMO it's not necessary, it's just a flag for an existing feature, not a new Yep, I guess that would be an exercise on its own :) -- To view, visit http://gerrit.cloudera.org:8080/18813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a05792db9dceb5e774ce1602158bb636bba04d0 Gerrit-Change-Number: 18813 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 03 Sep 2022 04:41:23 +0000 Gerrit-HasComments: Yes
