KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18834 )
Change subject: [tool] Add output format for 'table list' CLI tool. ...................................................................... Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/18834/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18834/14//COMMIT_MSG@10 PS14, Line 10: prett > pretty ? Done http://gerrit.cloudera.org:8080/#/c/18834/14//COMMIT_MSG@42 PS14, Line 42: > What's the significance of having this in the field? Is it possible to get Done http://gerrit.cloudera.org:8080/#/c/18834/10/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/10/src/kudu/tools/tool_action_table.cc@151 PS10, Line 151: new_table_name, " > Ah, indeed. Then maybe let's name this flag 'list_table_format' or 'list_t Done http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc@96 PS14, Line 96: map; > nit: should this be 'ostringstream' instead? Done http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc@159 PS14, Line 159: > nit: below the 'copy' algorithm is used without the 'std::' prefix; maybe a Done http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc@166 PS14, Line 166: } > nit: if adding 'using std::ostringstream', the std:: prefix might be omitte Done http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc@358 PS14, Line 358: > nit: since the validator for --list_table_output might be changed independe The 'pretty' values of the FLAGS_list_table_output_format means the normal output. The 'JsonWriter::Mode::PRETTY' of the mode means the output format fo the JsonWriter, that is the 'json' value of the FLAGS_list_table_output_format. -- To view, visit http://gerrit.cloudera.org:8080/18834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aaec73e18872fc93646e9c0ea675b578b0702f0 Gerrit-Change-Number: 18834 Gerrit-PatchSet: 15 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 05 Sep 2022 02:31:00 +0000 Gerrit-HasComments: Yes
