Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18834 )
Change subject: [tool] Add output format for 'table list' CLI tool. ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/18834/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18834/14//COMMIT_MSG@42 PS14, Line 42: > Done Well, my comment was about the " : " string in the JSON output. Is it possible to get rid of this part in case of JSON output, but still keep the meaningful information of the 'partition_info' field for JSON output format? http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/14/src/kudu/tools/tool_action_table.cc@358 PS14, Line 358: auto mode = iequals(FLAGS_list_table_output_format, "json") ? > The 'pretty' values of the FLAGS_list_table_output_format means the normal Yep, I know what the pretty-printed JSON output is. I meant adding the DCHECK() to spot an issue if in the future other format(s) added (e.g., CSV) and this piece of the code isn't updated: that's just to enforce the implicit assumptions in the code. If that isn't a concern at this point, that's fine. http://gerrit.cloudera.org:8080/#/c/18834/19/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/19/src/kudu/tools/tool_action_table.cc@336 PS19, Line 336: " : " My comment on the commit message in PS14 was about adding this " : " string in the JSON output. Is it possible to get rid of this part in case of JSON output? -- To view, visit http://gerrit.cloudera.org:8080/18834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aaec73e18872fc93646e9c0ea675b578b0702f0 Gerrit-Change-Number: 18834 Gerrit-PatchSet: 19 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 06 Sep 2022 19:17:00 +0000 Gerrit-HasComments: Yes
