Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18834 )
Change subject: [tool] Add output format for 'table list' CLI tool. ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/18834/15/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/18834/15/src/kudu/tools/tool_action_table.cc@168 PS15, Line 168: ostringstream ss; nit: how about use Substitute? http://gerrit.cloudera.org:8080/#/c/18834/15/src/kudu/tools/tool_action_table.cc@171 PS15, Line 171: copy(allowed_values.begin(), allowed_values.end(), : ostream_iterator<string>(ss, " ")); nit: how abour use JoinStrings? -- To view, visit http://gerrit.cloudera.org:8080/18834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aaec73e18872fc93646e9c0ea675b578b0702f0 Gerrit-Change-Number: 18834 Gerrit-PatchSet: 15 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 05 Sep 2022 16:46:18 +0000 Gerrit-HasComments: Yes
