Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18903 )
Change subject: KUDU-3379 Add column comments to table describe ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h@280 PS6, Line 280: std::string ToString(uint8_t to_string_mode = ToStringMode::WITHOUT_ATTRIBUTES) const; : > If doing so much bit-wise fun, maybe drop 'class' and have just 'enum ToStr I think I overcomplicated this part ... Yes, class is not really necessary, removed it. Because of this, and what you mentioned about class/enum scopes, the previous adjustment in 'src/kudu/tserver/tablet_service.cc' is also not needed. Moreover I made sure that whenever using ToStringMode, it is typed uint8_t. This way none of this operator overloading is necessary. Overall this simplified the patch. http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h@290 PS6, Line 290: const std::string& comment() const { : return comment_; > ditto ditto answer http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h@828 PS6, Line 828: return false; : } > ditto ditto answer http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h@837 PS6, Line 837: } : > ditto ditto answer http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/tools/kudu-admin-test.cc@1930 PS6, Line 1930: ASSERT_OK(builder.Build(&schema)); : } > nit: please follow the same approach for both parameters here -- you either Done http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/tools/kudu-admin-test.cc@2100 PS6, Line 2100: " \"long\"\n" : " ],\n" > nit: move this to be outside of the scope, to precede the corresponding TES Done -- To view, visit http://gerrit.cloudera.org:8080/18903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 8 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 09 Sep 2022 19:19:34 +0000 Gerrit-HasComments: Yes
