Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/18903 )
Change subject: KUDU-3379 Add column comments to table describe ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/18903/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18903/8//COMMIT_MSG@9 PS8, Line 9: to the 'kudu table des > nit: ... to the 'kudu table describe' CLI tool Done http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/common/schema.cc@159 PS8, Line 159: mode) const { > nit: what's the rationale behind this renaming? 'mode' looked good enough Tunnel vision :/ When I removed the enum type, which was descriptive, I immediately changed the parameters name. (forgot to look at the function name) Obviously you are right, changed back to the original mode naming. Thanks for catching this. http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/tools/kudu-admin-test.cc@2198 PS8, Line 2198: .Create()); > nit: is this crucial to set this to make the scenario work? If yes, conside I checked, it is not necessary. Removed it. http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/tools/kudu-admin-test.cc@2199 PS8, Line 2199: > nit: is this crucial for the scenario to have this set? If not, drop this I checked, it is not necessary. Removed it. -- To view, visit http://gerrit.cloudera.org:8080/18903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 9 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 13 Sep 2022 13:50:42 +0000 Gerrit-HasComments: Yes
