Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18903 )
Change subject: KUDU-3379 Add column comments to table describe ...................................................................... Patch Set 8: Code-Review+1 (5 comments) overall looks good to me, just a few nits http://gerrit.cloudera.org:8080/#/c/18903/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18903/8//COMMIT_MSG@9 PS8, Line 9: to kudu table describe nit: ... to the 'kudu table describe' CLI tool http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/18903/6/src/kudu/common/schema.h@280 PS6, Line 280: std::string ToString(uint8_t to_string_mode = ToStringMode::WITHOUT_ATTRIBUTES) const; : > I think I overcomplicated this part ... Yes, class is not really necessary, SGTM, thank you for the update. http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/common/schema.cc@159 PS8, Line 159: to_string_mode nit: what's the rationale behind this renaming? 'mode' looked good enough given the context, otherwise why not to rename into 'to_string_mode_for_column_schema_in_kudu_project' ? :) http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/tools/kudu-admin-test.cc@2198 PS8, Line 2198: .num_replicas(1) nit: is this crucial to set this to make the scenario work? If yes, consider rather using the test-wide FLAGS_num_replicas parameter, otherwise just skip setting this parameter at all http://gerrit.cloudera.org:8080/#/c/18903/8/src/kudu/tools/kudu-admin-test.cc@2199 PS8, Line 2199: .set_owner("alice") nit: is this crucial for the scenario to have this set? If not, drop this for the sake of simplification -- To view, visit http://gerrit.cloudera.org:8080/18903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222 Gerrit-Change-Number: 18903 Gerrit-PatchSet: 8 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 12 Sep 2022 21:09:22 +0000 Gerrit-HasComments: Yes
