Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu cpp client bug when using replica_selection policy ...................................................................... Patch Set 14: (14 comments) http://gerrit.cloudera.org:8080/#/c/18877/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18877/12//COMMIT_MSG@9 PS12, Line 9: c++ > C++ Done http://gerrit.cloudera.org:8080/#/c/18877/12//COMMIT_MSG@15 PS12, Line 15: d adds uni > Is there a test which would fail for the scenario described above? I have added a unit test to cover the case. http://gerrit.cloudera.org:8080/#/c/18877/12//COMMIT_MSG@15 PS12, Line 15: g in client l > in the client library Done http://gerrit.cloudera.org:8080/#/c/18877/12//COMMIT_MSG@15 PS12, Line 15: fix > fixes Done http://gerrit.cloudera.org:8080/#/c/18877/12//COMMIT_MSG@15 PS12, Line 15: y a > adds Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/client/scan_token-test.cc@1495 PS12, Line 1495: // The unit test check whether replica_selection strategy work well. > Could you add a concise description what this test is checking for and how Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/client/scan_token-test.cc@1502 PS12, Line 1502: canner satisti > nit: what's 'replica factor'? Maybe, you meant 'replication factor'? If s Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/client/scan_token-test.cc@1506 PS12, Line 1506: rs is no > 'for scanning' or 'to scan' Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/client/scan_token-test.cc@1516 PS12, Line 1516: cluster_.reset(new InternalMiniCluster(env_, options)); > nit for here and below: this line is too long -- please strive to have at m DONE. But I think if a line max length is 80 rather than 100. we'd better fix ilint. At the file: src/kudu/.clang-format : ColumnLimit: 100 not 80. http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/client/scan_token-test.cc@1533 PS12, Line 1533: .rows > Count of what? Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/common/common.proto@316 PS12, Line 316: s in particular situations > in particular situations Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/common/common.proto@316 PS12, Line 316: kudu C++ clie > in the Kudu C++ client Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/tools/table_scanner.cc@172 PS12, Line 172: constexpr const char* const kReplicaSelectionClosest = "closest"; : constexpr const char* const kReplicaSelectionFirst = "first"; : constexpr const char* const kReplicaSelectionLeader = "leader > nit: order these lines by the name of the constant (alphabetically, ASCII) Done http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/18877/12/src/kudu/util/test_util.h@47 PS12, Line 47: mono_de > Why not to provide timeout as MonoDelta as is in this second macro paramete Done -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 14 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 17 Sep 2022 18:42:37 +0000 Gerrit-HasComments: Yes
