Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@152 PS18, Line 152: KuduClient::ReplicaSelection::LEADER_ONLY > Is this backward-compatible with already existing tests? IIRC, the default Ah, that's for a de-serialized ScanToken, so it's LEADER_ONLY by default. My bad. So, LEADER_ONLY by default looks good, indeed. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@205 PS18, Line 205: TableParameters Is it used anywhere? I couldn't find its usage, but I might be missing something. -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 18 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 26 Sep 2022 02:26:40 +0000 Gerrit-HasComments: Yes
