Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 19: (9 comments) Thanks for you crs. I have fixed and you can review it again. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@205 PS18, Line 205: te a table with > Is it used anywhere? I couldn't find its usage, but I might be missing som Sorry, That's medium code. I'll remove it. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@206 PS18, Line 206: one and empty > nit: replication_factor sorry, fixed. has removed. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@1495 PS18, Line 1495: partitions, 3 replication factor. > replica selection works as expected Done http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@1495 PS18, Line 1495: table > checks Done http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@1495 PS18, Line 1495: 1 > This Done http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@1502 PS18, Line 1502: of scanners is the numbers of leader > Get current scanner's statistics, and then: Done http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/client/scan_token-test.cc@1505 PS18, Line 1505: // CLOSEST_REPLICA the same as LEADER_ONLY, the probability is very low because of random : // pick, at our test case has 10 partitions. : // 3. If replica selection is FIRST_REPLICA, after scanned, : // every tserver's increment number of scann > There is still a chance this might happen, and I guess that might be the so Yes, It's better using a deterministic test case. I'll study it. I firstly mark a TODO. Maybe change it later, it depends on time I can take. http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/tools/table_scanner.cc@179 PS18, Line 179: kReplicaSelectionClosest, : kReplicaSelectionFirst, : kReplicaSelectionLeader > nit: the same as for the kReplicaSelectionXxx above, please order the eleme Done http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/18877/18/src/kudu/util/test_util.h@47 PS18, Line 47: timeout) do > nit: once this parameter is of MonoDelta type, the '_s' suffix isn't needed Done -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 19 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sat, 08 Oct 2022 01:52:12 +0000 Gerrit-HasComments: Yes
