KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )
Change subject: KUDU-3326 [master] add flag FLAGS_deleted_table_reserve_seconds to change the cluster-wide behavior of the DeleteTable() RPC. ...................................................................... Patch Set 20: (7 comments) http://gerrit.cloudera.org:8080/#/c/18864/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18864/19//COMMIT_MSG@15 PS19, Line 15: NOTE: this flag is useless if HMS is enabled. > nit: how about: Done http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/client/client-test.cc@5222 PS17, Line 5222: > I agree 1 second maybe too short, maybe 3 or 5 seconds? And besides, you ca Done http://gerrit.cloudera.org:8080/#/c/18864/19/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18864/19/src/kudu/master/catalog_manager.cc@411 PS19, Line 411: > nit: alignment Done http://gerrit.cloudera.org:8080/#/c/18864/19/src/kudu/master/catalog_manager.cc@416 PS19, Line 416: n > I guess that's because the reserve seconds has been specified by user while Done http://gerrit.cloudera.org:8080/#/c/18864/19/src/kudu/master/catalog_manager.cc@425 PS19, Line 425: e > nit: If Done http://gerrit.cloudera.org:8080/#/c/18864/19/src/kudu/master/catalog_manager.cc@2419 PS19, Line 2419: > nit: update the comments? Done http://gerrit.cloudera.org:8080/#/c/18864/19/src/kudu/master/catalog_manager.cc@2466 PS19, Line 2466: elete state > nit: Still naming 'reserve_seconds'? Done -- To view, visit http://gerrit.cloudera.org:8080/18864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc Gerrit-Change-Number: 18864 Gerrit-PatchSet: 20 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 19 Sep 2022 03:44:32 +0000 Gerrit-HasComments: Yes
