Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )
Change subject: KUDU-3326 [master] add flag FLAGS_deleted_table_reserve_seconds to change the cluster-wide behavior of the DeleteTable() RPC. ...................................................................... Patch Set 20: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/18864/17/src/kudu/master/catalog_manager.cc@2419 PS17, Line 2419: : // Reserve seconds equal 0 means delete it directly if default_deleted_table_reserve_seconds : // set to 0, which means the cluster-wide behavior of the DeleteTable() RPC is keep default, : // or the table is in soft-deleted status. : i > Yes, you put forward a very good improvement point. I am very happy to prop I'm glad you liked the idea :) Yes, it would be great if you could post a patch to implement that as above. Thank you very much for your contributions! -- To view, visit http://gerrit.cloudera.org:8080/18864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc Gerrit-Change-Number: 18864 Gerrit-PatchSet: 20 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 22 Sep 2022 17:30:45 +0000 Gerrit-HasComments: Yes
