Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Overall looks good to me, just a few nits and a request to add more test coverage for the newly introduced functionality. http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG@9 PS2, Line 9: implemention implementation http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc@9186 PS2, Line 9186: class ClientTestUnixSocket : public ClientTest { Does it make sense to add 'positive' tests scenarios to alter a table, toggling the immutable attribute on a column? Also, it seems in client-test.cc there isn't coverage for 'positive' scenarios to alter a table, adding a column with immutable attribute set. Does it make sense to add such tests as well? -- To view, visit http://gerrit.cloudera.org:8080/18996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba Gerrit-Change-Number: 18996 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 23 Sep 2022 17:18:26 +0000 Gerrit-HasComments: Yes
