Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc@9186 PS2, Line 9186: class ClientTestUnixSocket : public ClientTest { > Do you mean some test cases like in alter_table-test.cc? The tests there ha Yes, those look good, thanks! It seems I posted my comments prematurely since I was traveling (was in an airport). -- To view, visit http://gerrit.cloudera.org:8080/18996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba Gerrit-Change-Number: 18996 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 24 Sep 2022 23:10:36 +0000 Gerrit-HasComments: Yes
