Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG@9 PS2, Line 9: implemention > implementation Done http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc@9186 PS2, Line 9186: class ClientTestUnixSocket : public ClientTest { > Does it make sense to add 'positive' tests scenarios to alter a table, togg Do you mean some test cases like in alter_table-test.cc? The tests there have cover the scenarios when the cluster supports 'immutable column attribute' feature: 1. alter column from default (mutable) to Immutable, then check attribute, read and write 2. alter column from immutable to mutable, then check attribute, read and write 3. add a column with immutable attribute, then check attribute, read and write links: 1. https://gerrit.cloudera.org/c/18996/2/src/kudu/integration-tests/alter_table-test.cc#2555 -- To view, visit http://gerrit.cloudera.org:8080/18996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba Gerrit-Change-Number: 18996 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 24 Sep 2022 16:03:29 +0000 Gerrit-HasComments: Yes
