Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 )
Change subject: [Client] Add request id to trace the whole query process ...................................................................... Patch Set 17: (3 comments) > Patch Set 14: > > (5 comments) http://gerrit.cloudera.org:8080/#/c/18846/14/java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java File java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java: http://gerrit.cloudera.org:8080/#/c/18846/14/java/kudu-client/src/main/java/org/apache/kudu/client/AbstractKuduScannerBuilder.java@61 PS14, Line 61: String requestId = ""; > I find C++ client has a default random uuid. Java client may do this as C+ Done http://gerrit.cloudera.org:8080/#/c/18846/14/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/18846/14/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@238 PS14, Line 238: KuduTable table = client.createTable(tableName, getBasicSchema(), getBasicCreateTableOptions()); > The 'table' is create just now, there is no rows in the table. Scan is empt Done http://gerrit.cloudera.org:8080/#/c/18846/14/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/18846/14/src/kudu/tserver/tablet_service.cc@3036 PS14, Line 3036: "request_id", req->request_id(), > If kudu client is not match kudu server, old kudu client may send scan req I have test, it will have a default value when scanning with old client without request id. -- To view, visit http://gerrit.cloudera.org:8080/18846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dbae801596726fec1c85ee547128da3179345d9 Gerrit-Change-Number: 18846 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 26 Sep 2022 11:39:20 +0000 Gerrit-HasComments: Yes
