Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19197 )
Change subject: KUDU-3406: add --memory_flush_prioritization_prob flag ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19197/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19197/1/src/kudu/util/maintenance_manager.cc@538 PS1, Line 538: if (!best_perf_improvement_op || best_perf_improvement <= 0 || > You are right -- that's what I was also looking at. I also saw an evidence I think it would be simple and less intrusive to have some kind of preference mechanism wherein we give preference to compaction op after every n consecutive occasions when best_perf_op is chosen as any flush op. Changing the logic inside SetPerfImprovementForFlush may end up impacting total mechanism more than we want. So, we can simply set best_perf_op as compaction, if we have above condition satisfied even though score wise flush op may be greater in value. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/19197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e33bcebe7284da20e57dfbc9d87070f92fd6f3 Gerrit-Change-Number: 19197 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 04 Nov 2022 06:48:43 +0000 Gerrit-HasComments: Yes
