Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19197 )
Change subject: KUDU-3406: add --memory_flush_prioritization_prob flag ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19197/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/19197/1/src/kudu/util/maintenance_manager.cc@538 PS1, Line 538: if (!best_perf_improvement_op || best_perf_improvement <= 0 || > I think it would be simple and less intrusive to have some kind of preferen Yep, that might be a solution, but it requires accumulating some state, and ideally that should be per-tablet replica, and it not exactly accounting for the memory needed to execute compaction. Since you looked at the compaction stuff a bit, maybe you can see if it's easier to include the amount of memory needed for executing the compaction? If it grows high, the score should get higher and higher, so with the flush/compaction preference flag it will provide a better heuristic to make a decision. -- To view, visit http://gerrit.cloudera.org:8080/19197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e33bcebe7284da20e57dfbc9d87070f92fd6f3 Gerrit-Change-Number: 19197 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 07 Nov 2022 16:30:58 +0000 Gerrit-HasComments: Yes
