Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19197 )

Change subject: KUDU-3406: add --memory_flush_prioritization_prob flag
......................................................................


Patch Set 1:

(1 comment)

We can have this flag in place until the long term fixes land.
Since there is still a chance for the compaction to be completed in a longer 
period of time, in case of a single maintenance manager thread it might cause 
the flushing to not take place until this compaction is done. So do you think 
it makes sense to change the number of maintenance threads default to 2?

http://gerrit.cloudera.org:8080/#/c/19197/1/src/kudu/util/maintenance_manager.cc
File src/kudu/util/maintenance_manager.cc:

http://gerrit.cloudera.org:8080/#/c/19197/1/src/kudu/util/maintenance_manager.cc@548
PS1, Line 548: VLOG(1)
Is there a reason behind not having this set to INFO level? As I think that 
might help in memory troubleshooting scenarios. Probably we could do the same 
with line 570.



--
To view, visit http://gerrit.cloudera.org:8080/19197
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07e33bcebe7284da20e57dfbc9d87070f92fd6f3
Gerrit-Change-Number: 19197
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 14 Nov 2022 21:02:38 +0000
Gerrit-HasComments: Yes

Reply via email to