Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 21: (3 comments) Glad to receive your crs. Thanks. http://gerrit.cloudera.org:8080/#/c/18877/21/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/18877/21/src/kudu/client/scan_token-internal.cc@427 PS21, Line 427: } > Add line break. I think It's not necessary adding a 'break' after 'return', is there some basis? http://gerrit.cloudera.org:8080/#/c/18877/19/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/19/src/kudu/client/scan_token-test.cc@1491 PS19, Line 1491: // This unit test checks whether LEADER_ONLY replica selection works as expected. > I mean since it's flaky, we can temporarily disable this test case, see goo Thanks your method. Although, it's not a deterministic test case for LeaderOnly, It's also a necessary condition for Leader-Only's correctness, so keep the case opened is useful. http://gerrit.cloudera.org:8080/#/c/18877/21/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/21/src/kudu/client/scan_token-test.cc@1498 PS21, Line 1498: TEST_F(ScanTokenTest, TestReplicaSelectionLeaderOnly) { > These three test scenarios have a lot of the same code. It seems that they OK, I'll do it later. -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 21 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Mon, 07 Nov 2022 17:00:00 +0000 Gerrit-HasComments: Yes
