Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 23: (5 comments) http://gerrit.cloudera.org:8080/#/c/18877/23/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/23/src/kudu/client/scan_token-test.cc@1582 PS23, Line 1582: // Do this as below: nit: Remove this line. http://gerrit.cloudera.org:8080/#/c/18877/23/src/kudu/client/scan_token-test.cc@1606 PS23, Line 1606: ASSERT_LE Should this be ASSERT_EQ? http://gerrit.cloudera.org:8080/#/c/18877/23/src/kudu/client/scan_token-test.cc@1641 PS23, Line 1641: map<string, int32_t> uuid_scan_count; Seems that L1641-L1657 is repeated in multiple test cases. http://gerrit.cloudera.org:8080/#/c/18877/23/src/kudu/client/scan_token-test.cc@1668 PS23, Line 1668: at least one tserver's increment : // number of scanners is not the numbers of leaders. Is this always true? If not, there is a probability that this test will fail, right? http://gerrit.cloudera.org:8080/#/c/18877/23/src/kudu/client/scan_token-test.cc@1671 PS23, Line 1671: ASSERT_GE(leader_row_count, closest_replica_row_count); Can we replace 'ASSERT_LE' and 'ASSERT_GE' with 'ASSERT_EQ' here? -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 23 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 13:47:19 +0000 Gerrit-HasComments: Yes
