Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 19: (1 comment) Thanks your crs. http://gerrit.cloudera.org:8080/#/c/18877/19/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/19/src/kudu/client/scan_token-test.cc@1491 PS19, Line 1491: // TODO(duyuqi), provide a determinstic test case. > nit: Maybe you can separate these three test cases and disable the 'CLOSEST split it into 3, I see. but disable CLOSEST_REPLICA, what means? Reserve 2 test cases(LEADER_ONLY, FIRST_REPLICA)? Although CLOSEST_REPLICA case is not determinstic, but its useful. -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 19 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 21 Oct 2022 08:54:34 +0000 Gerrit-HasComments: Yes
