Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 )
Change subject: util: pull jwt code from Impala ...................................................................... Patch Set 9: Code-Review+1 (3 comments) Overall looks good to me, but please address Wenzhe's comment athttps://gerrit.cloudera.org/#/c/18467/7/src/kudu/util/jwt-util.cc@734 http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/util/jwt-util.cc@272 PS2, Line 272: otAut > This is a bit weird, I think it's okay if we move these to constant, but th Yep -- I agree: that can be taken care of separately, if needed. So, I'm OK with leaving this as-is for now. http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/util/jwt-util.cc@688 PS2, Line 688: if (jwks_update_thread_ != nullptr) jwks_update_thread_->Join() > Sorry I haven't replied to this. The only reason why this may be okay as a Thank you for the analysis. It would be great if you could add a blurb to put that information as a code's comment. http://gerrit.cloudera.org:8080/#/c/18467/7/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18467/7/src/kudu/util/jwt-util.cc@734 PS7, Line 734: << status.ToString(); > define a variable for MonoDelta::FromMilliseconds(timeout_millis) out of th Yup, that's what I was trying to recommend as well, but failed to articulate properly. Thanks for the clarification, Wenzhe! -- To view, visit http://gerrit.cloudera.org:8080/18467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib546762aa7ff53009f32688c30c5642ee4df494b Gerrit-Change-Number: 18467 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 02:22:55 +0000 Gerrit-HasComments: Yes
