Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 )
Change subject: util: pull jwt code from Impala ...................................................................... Patch Set 10: (2 comments) Overall looks good to me. Only two minor comments. http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc@718 PS10, Line 718: the file the URI nit: the file which the URI http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc@732 PS10, Line 732: bool timed_out = shut_down_promise_.WaitFor(timeout); WaitFor() returns nullptr if the timeout elapses so timed_out should be true if WaitFor() returns nullptr. We should break the loop if it's NOT timed out. bool timed_out = (shut_down_promise_.WaitFor(timeout) == nullptr). if (!timed_out) break; or if (shut_down_promise_.WaitFor(timeout) != nullptr) break; -- To view, visit http://gerrit.cloudera.org:8080/18467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib546762aa7ff53009f32688c30c5642ee4df494b Gerrit-Change-Number: 18467 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 19:34:01 +0000 Gerrit-HasComments: Yes
