Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 )
Change subject: util: pull jwt code from Impala ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc@718 PS10, Line 718: the file which U > nit: the file which the URI Done http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc@728 PS10, Line 728: const MonoDelta &timeout = MonoDelta::FromSeconds(FLAGS_jwks_update_frequency_s); : > nit: this could be just Done http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/util/jwt-util.cc@732 PS10, Line 732: // Shutdown has happened, stop updating JWKS. > Good point. I'd vote for Done -- To view, visit http://gerrit.cloudera.org:8080/18467 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib546762aa7ff53009f32688c30c5642ee4df494b Gerrit-Change-Number: 18467 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 16:20:13 +0000 Gerrit-HasComments: Yes
