Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 28: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/18877/20/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/20/src/kudu/client/scan_token-test.cc@1520 PS20, Line 1520: session->SetTimeoutMillis(10000); > I can reduce it. 1000 Now is it needed to add `ASSERT_EVENTUALLY_WITH_TIMEOUT`? I don't think insert 1000 rows would last so long time. http://gerrit.cloudera.org:8080/#/c/18877/28/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/28/src/kudu/client/scan_token-test.cc@266 PS28, Line 266: int32_t bucket_num, alignment -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 28 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 13 Nov 2022 15:54:59 +0000 Gerrit-HasComments: Yes
