Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 )
Change subject: [metrics] Expose Prometheus Metrics in Kudu ...................................................................... Patch Set 11: > Patch Set 10: > > > Uploaded patch set 10. > > There are build failures in PS10: > > 11:21:37 > /home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/metrics.cc: In > member function 'virtual kudu::Status > kudu::Histogram::WriteAsPrometheus(PrometheusWriter*, const string&) const': > 11:21:37 > /home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/metrics.cc:1100:41: > error: ISO C++ forbids taking the address of an unqualified or parenthesized > non-static member function to form a pointer to member function. Say > '&kudu::Histogram::snapshot' [-fpermissive] > 11:21:37 RETURN_NOT_OK(GetHistogramSnapshotPB(&snapshot, opts)); > 11:21:37 ^ > 11:21:37 > /home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/status.h:41:33: > note: in definition of macro 'KUDU_RETURN_NOT_OK' > 11:21:37 const ::kudu::Status& _s = (s); \ > 11:21:37 ^ > 11:21:37 > /home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/metrics.cc:1100:3: > note: in expansion of macro 'RETURN_NOT_OK' > 11:21:37 RETURN_NOT_OK(GetHistogramSnapshotPB(&snapshot, opts)); My bad, messed up reformatting a comment. -- To view, visit http://gerrit.cloudera.org:8080/19133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2d01bd56f6f0f1b6f31cbce15e671d16521739 Gerrit-Change-Number: 19133 Gerrit-PatchSet: 11 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 21:46:49 +0000 Gerrit-HasComments: No
