Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 )
Change subject: [metrics] Expose Prometheus Metrics in Kudu ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Overall looks good to me, please address Yingchun's comments and one more nit. http://gerrit.cloudera.org:8080/#/c/19133/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19133/11//COMMIT_MSG@36 PS11, Line 36: do not need to be converted to seconds which is the base time unit in Prometheus. : : More information on Prometheus Metric units and naming conventions can be found at: nit: strive to keep lines' length under 72 symbols, the guide is at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines (it can be found at the https://kudu.apache.org/docs/contributing.html#_submitting_patches page). -- To view, visit http://gerrit.cloudera.org:8080/19133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2d01bd56f6f0f1b6f31cbce15e671d16521739 Gerrit-Change-Number: 19133 Gerrit-PatchSet: 12 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 16:00:51 +0000 Gerrit-HasComments: Yes
