Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 )
Change subject: KUDU-3375 [metrics] Expose Prometheus Metrics in Kudu ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/19133/13/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/19133/13/src/kudu/util/metrics.cc@902 PS13, Line 902: writer->WriteEntry(Substitute("$0$1{unit_type=\"$2\"} $3\n", : prefix, prototype_->name(), : MetricUnit::Name(prototype_->unit()), value())); : } If, according to the comment in StringGauge::WriteAsPrometheus(), string gauges aren't supported in Prometheus format, then why to implement this method at all? Maybe, this implementation should do nothing? -- To view, visit http://gerrit.cloudera.org:8080/19133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2d01bd56f6f0f1b6f31cbce15e671d16521739 Gerrit-Change-Number: 19133 Gerrit-PatchSet: 13 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 09 Nov 2022 18:41:44 +0000 Gerrit-HasComments: Yes
