Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 )
Change subject: KUDU-3375 Expose Prometheus Metrics in Kudu ...................................................................... Patch Set 16: (1 comment) Added the comment as well. Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/19133/15/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/19133/15/src/kudu/util/metrics.cc@902 PS15, Line 902: // (see https://prometheus.io/docs/instrumenting/exposition_formats/). : // DCHECK() is added to make sure this method is not called from anywhere, : // but overriding it is necessary since Gauge::WriteValue() is a pure virtual one. : // An alternative could be defining a empty implementation for Gauge::WriteValue() : // virtual method and not adding this empty override here. : void StringGauge::WriteValue(PrometheusWriter* writer, const std::string& prefi > Instead of this piece of unused code that the compiler takes time to proces Done -- To view, visit http://gerrit.cloudera.org:8080/19133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2d01bd56f6f0f1b6f31cbce15e671d16521739 Gerrit-Change-Number: 19133 Gerrit-PatchSet: 16 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 02:40:30 +0000 Gerrit-HasComments: Yes
