Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 )
Change subject: KUDU-3375 Expose Prometheus Metrics in Kudu ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/19133/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19133/13//COMMIT_MSG@7 PS13, Line 7: KUDU-3375 Expose Pr > nit: just for future reference, please use either 'KUDU-3375' or '[metrics] Okay http://gerrit.cloudera.org:8080/#/c/19133/13/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/19133/13/src/kudu/util/metrics.cc@418 PS13, Line 418: // Status::NotFound is returned when this entity has been filtered, treat it : // as OK, and skip printing it. : return Status::OK(); : } : R > Could you please just add proper status code handling here for GetMetricsAn Done http://gerrit.cloudera.org:8080/#/c/19133/13/src/kudu/util/metrics.cc@907 PS13, Line 907: MetricUnit::Name(prototype_->unit()),value())); : DCHECK(false); : } : : S > OK, thanks for the update. The desired result should be fully empty, as leaving comments without actually having a actual line representing the metric might lead to some incorrect parsing of the data now that I think about it. I've added a DCHECK to StringGauge::WriteValue() and restored the implementation in case Prometheus starts supporting String Gauges, along with adding an empty reimplementation of StringGauge::WriteAsPrometheus(). -- To view, visit http://gerrit.cloudera.org:8080/19133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b2d01bd56f6f0f1b6f31cbce15e671d16521739 Gerrit-Change-Number: 19133 Gerrit-PatchSet: 15 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 01:18:38 +0000 Gerrit-HasComments: Yes
