Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util-test.cc@1194 PS11, Line 1194: Sockaddr addr_ not used http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util.cc@30 PS11, Line 30: #include <cstdint> : #include <cstdio> nit: move these two lines to line #23 to keep alphabet order http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util.cc@405 PS11, Line 405: &BN_free nit: alignment http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util.cc@717 PS11, Line 717: bool timed_out = shut_down_promise_.WaitFor(timeout); : if (timed_out) break; rebase with parent patch http://gerrit.cloudera.org:8080/#/c/18468/11/src/kudu/util/jwt-util.cc@872 PS11, Line 872: RETURN_NOT_OK(status) return status; -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 11 Nov 2022 19:42:57 +0000 Gerrit-HasComments: Yes
