Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/18468/13/src/kudu/util/jwt-util-test.cc File src/kudu/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/18468/13/src/kudu/util/jwt-util-test.cc@1194 PS13, Line 1194: > nit: it seems this is unused, as pointed by Wenzhe in one of earlier revisi Ack http://gerrit.cloudera.org:8080/#/c/18468/13/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18468/13/src/kudu/util/jwt-util.cc@202 PS13, Line 202: std::unique_ptr<JWTPublicKey> jwt_pub_key; : RETURN_NOT_OK(HSJWTPublicKeyBuilder:: > Thanks to catch memory leak issue. Agree to change to unique pointer to avo I've updated the signatures of the AddXXKey methods to pass unique_ptrs. As for creating a destructor, it's not necessary, since the key maps are JWTPublicKeyMaps, which is: typedef std::unordered_map<std::string, std::unique_ptr<JWTPublicKey>> JWTPublicKeyMap; so the cleanup should be automatic. -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 16 Nov 2022 19:28:00 +0000 Gerrit-HasComments: Yes
