Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h File src/kudu/util/jwt-util-internal.h: http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h@28 PS15, Line 28: #include <memory> nit: move this into the group of the standard C++ headers above http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h@48 PS15, Line 48: nit: the indent is off (should be 2 spaces from the beginning of the line) http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h@209 PS15, Line 209: std::unique_ptr<JWTPublicKey>& style (here and for all other methods): for output parameters, use pointers, not references. http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h@247 PS15, Line 247: nit: the indent is off http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util.cc@202 PS15, Line 202: std::unique_ptr<JWTPublicKey> jwt_pub_key; : RETURN_NOT_OK(HSJWTPublicKeyBuilder::CreateJWKPublicKey(kv_map, jwt_pub_key)); : jwks_->AddHSKey(key_id, jwt_pub_key); I thought it would be something like below: unique_ptr<JWTPublicKey> jwt_pub_key; RETURN_NOT_OK(HSJWTPublicKeyBuilder::CreateJWKPublicKey(kv_map, &jwt_pub_key)); jwks_->AddHSKey(key_id, std::move(jwt_pub_key)); -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 03:46:17 +0000 Gerrit-HasComments: Yes
