Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 )
Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy ...................................................................... Patch Set 30: (3 comments) Thank you. http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc@1599 PS29, Line 1599: > Since the test cluster is set up in every test case, there should be no sca Done http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc@1683 PS29, Line 1683: // This unit test checks whether FIRST_REPLICA replica selection works as expected. > I still don't think it's a good way to test the 'CLOSEST_REPLICA' policy. Thank you point out the deterministic code. It can be used to construct the test case. http://gerrit.cloudera.org:8080/#/c/18877/29/src/kudu/client/scan_token-test.cc@1718 PS29, Line 1718: vector<tserver::ScanDescriptor> scanners = > Should it be ASSERT_GE? The first replica could also be a follower. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/18877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2 Gerrit-Change-Number: 18877 Gerrit-PatchSet: 30 Gerrit-Owner: Yuqi Du <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 15 Nov 2022 04:38:12 +0000 Gerrit-HasComments: Yes
