Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 )
Change subject: jwt: add test for fetching JWKS via URL ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h File src/kudu/util/jwt-util-internal.h: http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h@246 PS15, Line 246: Add destructor function http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util-internal.h@292 PS15, Line 292: & remove & http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util.cc@56 PS15, Line 56: #include <memory> don't need this line since it's already included in jwt-util.h http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util.cc@285 PS15, Line 285: nit: 4 spaces http://gerrit.cloudera.org:8080/#/c/18468/15/src/kudu/util/jwt-util.cc@329 PS15, Line 329: nit: 4 spaces -- To view, visit http://gerrit.cloudera.org:8080/18468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief272c813b62e789d747a88e1f3be8c406eed3f8 Gerrit-Change-Number: 18468 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 05:59:19 +0000 Gerrit-HasComments: Yes
