Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/client-unittest.cc File src/kudu/client/client-unittest.cc: http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/client-unittest.cc@163 PS2, Line 163: SetNonUniquePrimaryKey Have another test setting this to primary key http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.cc@656 PS2, Line 656: , Delete http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.cc@660 PS2, Line 660: , Delete http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.cc@757 PS2, Line 757: + nit: Here and below missing space around the operators "+" and "," -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sun, 04 Dec 2022 18:50:02 +0000 Gerrit-HasComments: Yes
