Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19272 )
Change subject: KUDU-1945 Auto-Incrementing Column, C++ client ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/scan_token-internal.cc@207 PS2, Line 207: for (const int column_idx : message.projected_column_idx()) { : column_indexes.push_back(column_idx); : } If projected_column_idx are not set, all of columns including auto_increment_id column will be added to scan token. Should we add an API or flag to control if auto_increment_id column will be added to scan token by default? At least we should document this behavior. http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/19272/2/src/kudu/client/schema.h@766 PS2, Line 766: The placeholder for the result. What's the return value if there is no auto_incrementing_column? -1? -- To view, visit http://gerrit.cloudera.org:8080/19272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic133e3d44cc56c8351e33d95b523ed7b6b13617b Gerrit-Change-Number: 19272 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 00:03:11 +0000 Gerrit-HasComments: Yes
