Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/messenger.h@380 PS16, Line 380: *jwt_verifier_ Once jwt_verifier_ might be a wrapper around nullptr, this might become an undefined behavior when this method is called. With that, I guess there are a few options here: * remove this method and leave only mutable_jwt_verifier() * change this method to return constant pointer 'const JwtVerifier*', not a const reference http://gerrit.cloudera.org:8080/#/c/18469/13/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/18469/13/src/kudu/rpc/messenger.cc@324 PS13, Line 324: rpcz_store_(new RpczStore), > yeah, I changed this to nullptr in the previous changeset, is that what you Yep: what I see in PS14 (this is PS13) looks like what I meant, thanks. -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 16 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 07 Dec 2022 18:09:32 +0000 Gerrit-HasComments: Yes
