Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 15: (2 comments) It seems IWYU isn't happy yet: 03:58:10 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/2/src/kudu/rpc/messenger.cc' 03:58:10 @@ -46,7 +46,6 @@ 03:58:10 #include "kudu/security/tls_context.h" 03:58:10 #include "kudu/security/token_verifier.h" 03:58:10 #include "kudu/util/flags.h" 03:58:10 -#include "kudu/util/jwt.h" 03:58:10 #include "kudu/util/metrics.h" 03:58:10 #include "kudu/util/monotime.h" 03:58:10 #include "kudu/util/net/socket.h" 03:58:10 IWYU would have edited 1 files on your behalf. http://gerrit.cloudera.org:8080/#/c/18469/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18469/13//COMMIT_MSG@10 PS13, Line 10: It is limited in the sense that JWTs can be sent over encrypted : channels > Updated the commit message to reflect the actual behaviour. Thank you! http://gerrit.cloudera.org:8080/#/c/18469/13/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/18469/13/src/kudu/rpc/messenger.cc@324 PS13, Line 324: jwt_verifier_(nullptr), > As jwt_verifier_ is declared as a shared_ptr it's not possible to assign st We could leave that std::shared_ptr as null wrapper. Would that work? -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 07 Dec 2022 00:28:34 +0000 Gerrit-HasComments: Yes
