Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18469 )
Change subject: rpc: plumb JWTs into the RPC layer ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/messenger.h File src/kudu/rpc/messenger.h: http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/messenger.h@380 PS16, Line 380: jwt_verifier_. > Once jwt_verifier_ might be a wrapper around nullptr, this might become an Ack http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/server_negotiation.cc@504 PS16, Line 504: if (jwt_verifier_) { > When JWT verifier can be nullptr, this shouldn't be added into the availabl Done http://gerrit.cloudera.org:8080/#/c/18469/16/src/kudu/rpc/server_negotiation.cc@727 PS16, Line 727: t_raw()) { > This can be null if no JWT verifier is installed in the messenger. Done -- To view, visit http://gerrit.cloudera.org:8080/18469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I252f1e597d9df4408379c3b695f266dbd7f48dcc Gerrit-Change-Number: 18469 Gerrit-PatchSet: 17 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 08 Dec 2022 17:53:57 +0000 Gerrit-HasComments: Yes
