Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/client/client-test.cc@9585 PS8, Line 9585: ->NotNull()->AutoIncrementing(); set auto_incrementing column as primary key http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/client/schema.cc@488 PS8, Line 488: if (data_->auto_incrementing && internal_type != kudu::UINT64) { auto_incrementing column should be primary_key, consolidate all sanity checks for auto_incrementing as if (data_->auto_incrementing) { if (data_->default_val) { ... } else if (!data_->primary_key) { ... } else if (internal_type != kudu::UINT64) { ... } else if (nullable) { ... } else if () } http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.h@231 PS8, Line 231: ColumnSchema col_c("c", INT32, false, false, &default_i32); : // Slice default_str("Hello"); : // ColumnSchema col_d("d", STRING, false, false, &default_str); : // ColumnSchema col_e("d", STRING, false, false, &default_str, false); is_auto_incrementing should be added as 5-th parameter http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.cc@301 PS8, Line 301: TODO:(achennaka) This should be enforced in KuduColumnSpec::ToColumnSchema() http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.cc@653 PS8, Line 653: nullable or immutabl nit: copy/paste error -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 08 Dec 2022 22:05:01 +0000 Gerrit-HasComments: Yes
