Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19097 )
Change subject: KUDU-1945 Auto-Incrementing Column ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/client/client-test.cc@9638 PS8, Line 9638: } add some negative test cases, like set value for auto_incrementing_id column when inserting rows, wrong ColumnSchema settings, etc. http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/common/schema.h@221 PS8, Line 221: is_auto_incrementing: true if the column is auto-incrementing column. : // Auto-incrementing column cannot be updated but written to by a client and is auto : // filled in by Kudu by incrementing the previous highest written value to the tablet. : // There can only be a single auto-incrementing column per table. move this block to line #215 http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/tablet/tablet_auto_incrementing-test.cc File src/kudu/tablet/tablet_auto_incrementing-test.cc: http://gerrit.cloudera.org:8080/#/c/19097/8/src/kudu/tablet/tablet_auto_incrementing-test.cc@81 PS8, Line 81: } add some negative test cases here. -- To view, visit http://gerrit.cloudera.org:8080/19097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dbde9095da78f6d1bd00adcc0a6e7dd63082bbc Gerrit-Change-Number: 19097 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 08 Dec 2022 22:23:38 +0000 Gerrit-HasComments: Yes
